Adds tracking of overall authorized amount for each application #166
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: David Núñez <[email protected]> Co-authored-by: Michalina <[email protected]>
…m governance contracts Co-authored-by: Michalina <[email protected]>
Co-authored-by: Michalina <[email protected]>
theref
approved these changes
Mar 27, 2024
cygnusv
reviewed
Apr 5, 2024
| ]; | ||
| int96 authorizedOverall = authorizedOverallValues[i]; | ||
| if (authorizedOverall >= 0) { | ||
| applicationStruct.authorizedOverall += uint96( |
There was a problem hiding this comment.
Why not directly setting applicationStruct.authorizedOverall, rather than using int96 increments/decrements?
There was a problem hiding this comment.
because with just setting value we always can face frontrun tx that will change authorization and now we have to execute one more tx. With addition or subtraction - maximum we need two txs even if one/many will be executed right before upgrade
cygnusv
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #159
At some moment in the future we want to have contract that will calculate reward per app on chain. For this purpose such contract will need to know overall amount authorized for each application. This PR adds tracking of those values and also one-time function to initialize variables. It's not feasible to calculate current authorized value in contract because we don't have list of all staking providers on chain.
updateAuthorizedOverallallows to add or subtract values from currentauthorizedOverall, it needed in case before upgrading will be any change in authorization amount. Suggested upgrading sequence: calculate authorized amounts right before upgrading, upgrade +updateAuthorizedOverall, in case there is any tx that changes authorization between two previous steps - executeupdateAuthorizedOverallagain.